r204038 - clang/test/CXX/drs: Add "REQUIRES:LP64" to a couple of tests in r204033. [PR8833]

[Richard Smith]

On Mon, Mar 17, 2014 at 4:02 PM, NAKAMURA Takumi <geek4civic at gmail.com>wrote:

> The issue is rather PR13819 than PR8833.
> http://llvm.org/bugs/show_bug.cgi?id=13819
>
> error: 'error' diagnostics seen but not expected:
>   Line 9: 'long long' is a C++11 extension
>

We should fix __SIZE_TYPE__ to not rely on extensions =)

In the meantime, I've switched to a more directed fix in r204096.

2014-03-18 1:57 GMT+09:00 Richard Smith <richard at metafoo.co.uk>:
> > Neither of these tests should require LP64. This is probably a silly bug
> in
> > them. What's the nature of the failure?
> >
> >
> > On Mon, Mar 17, 2014 at 4:55 AM, NAKAMURA Takumi <geek4civic at gmail.com>
> > wrote:
> >>
> >> Author: chapuni
> >> Date: Mon Mar 17 06:55:46 2014
> >> New Revision: 204038
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=204038&view=rev
> >> Log:
> >> clang/test/CXX/drs: Add "REQUIRES:LP64" to a couple of tests in r204033.
> >> [PR8833]
> >>
> >> Modified:
> >>     cfe/trunk/test/CXX/drs/dr412.cpp
> >>     cfe/trunk/test/CXX/drs/dr4xx.cpp
> >>
> >> Modified: cfe/trunk/test/CXX/drs/dr412.cpp
> >> URL:
> >>
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CXX/drs/dr412.cpp?rev=204038&r1=204037&r2=204038&view=diff
> >>
> >>
> ==============================================================================
> >> --- cfe/trunk/test/CXX/drs/dr412.cpp (original)
> >> +++ cfe/trunk/test/CXX/drs/dr412.cpp Mon Mar 17 06:55:46 2014
> >> @@ -6,6 +6,7 @@
> >>  // lwg404: yes
> >>  // lwg2340: yes
> >>
> >> +// REQUIRES: LP64
> >>  typedef __SIZE_TYPE__ size_t;
> >>  namespace std { struct bad_alloc {}; }
> >>  int x;
> >>
> >> Modified: cfe/trunk/test/CXX/drs/dr4xx.cpp
> >> URL:
> >>
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CXX/drs/dr4xx.cpp?rev=204038&r1=204037&r2=204038&view=diff
> >>
> >>
> ==============================================================================
> >> --- cfe/trunk/test/CXX/drs/dr4xx.cpp (original)
> >> +++ cfe/trunk/test/CXX/drs/dr4xx.cpp Mon Mar 17 06:55:46 2014
> >> @@ -396,6 +396,7 @@ namespace dr428 { // dr428: yes
> >>  }
> >>
> >>  namespace dr429 { // dr429: yes c++11
> >> +  // REQUIRES: LP64
> >>    // FIXME: This rule is obviously intended to apply to C++98 as well.
> >>    typedef __SIZE_TYPE__ size_t;
> >>    struct A {
> >>
> >>
> >> _______________________________________________
> >> cfe-commits mailing list
> >> cfe-commits at cs.uiuc.edu
> >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140317/343b7f35/attachment.html>