[PATCH][REVIEW REQUEST] Fix for libclang completion of already declared template friends.

[Richard Smith]

Your visibility check seems more complex than necessary. I think this
should do what you want:

if (ND->getMostRecentDecl()->isInIdentifierNamespace(Decl::IDNS_Ordinary |
Decl::IDNS_Tag))
  // visible


On Wed, Mar 12, 2014 at 2:12 PM, Francisco Lopes <
francisco.mailing.lists at oblita.com> wrote:

> Ping
>
>
> 2014-03-07 14:47 GMT-03:00 Francisco Lopes <
> francisco.mailing.lists at oblita.com>:
>
>> Hi,
>>
>> attached is a patch that tries to fix libclang bug 13699<http://llvm.org/bugs/show_bug.cgi?id=13699>
>> .
>> Please review.
>>
>> --
>> Francisco Lopes
>>
>> PS:
>> I have requested commit access in late 2012 but never made a test commit
>> or anything.
>>
>> At the time I have received from Chris Lattner:
>> "I'm sorry for the delay, I've been fighting mailing list issues.
>> Commit after approval access is granted.  Please try a test commit!"
>>
>> I'm not sure whether it's still valid.
>>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140313/f8a3d881/attachment.html>