OK to merge r200954 to 3.4 branch?

[Richard Smith]

Approved.


On Thu, Mar 13, 2014 at 11:24 AM, Tom Stellard <tom at stellard.net> wrote:

> Hi Richard,
>
> Do you approve merging this commit, which fixes
> http://llvm.org/bugs/show_bug.cgi?id=18473 to the 3.4 branch:
>
> r200954 | richard-llvm | 2014-02-06 15:35:16 -0800 (Thu, 06 Feb 2014) | 9
> lines
>
> Temporary fix for PR18473: Don't try to evaluate the initializer for a
> type-dependent variable, even if the initializer isn't value-dependent.
> This happens for ParenListExprs composed of non-value-dependent
> subexpressions, for instance.
>
> We should really give ParenListExprs (and InitListExprs) the type of the
> initialized entity if they're used to represent a dependent initialization
> (and
> if so, set them to be type-, value- and instantiation-dependent).
>
>
> Thanks,
> Tom
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140313/ccf897b6/attachment.html>