[PATCH] Allow _MSC_EXTENSIONS macro on non-Windows targets

Richard Smith richard at metafoo.co.uk
Wed Mar 12 19:27:43 PDT 2014



================
Comment at: lib/Lex/PPMacroExpansion.cpp:1043
@@ -1042,2 +1042,3 @@
            .Case("cxx_variable_templates", LangOpts.CPlusPlus)
+           .Case("msvc_keywords", LangOpts.MicrosoftExt)
            .Default(false);
----------------
I'm opposed to having something so vague and general. What happens when we add support for more MS keywords?

Please make the extension check be a test for a specific extension.


http://llvm-reviews.chandlerc.com/D3034



More information about the cfe-commits mailing list