[PATCH] Use enable_if to prevent operator<<(DiagnosticBuilder&, bool) from being called for pointer arguments
Richard Smith
richard at metafoo.co.uk
Wed Mar 12 13:35:42 PDT 2014
Great idea, LGTM. Thanks!
================
Comment at: lib/Sema/SemaDeclCXX.cpp:6567
@@ -6566,4 +6566,3 @@
else
- S.Diag(Loc, diag::err_inline_namespace_mismatch)
- << IsInline;
+ S.Diag(Loc, diag::err_inline_namespace_mismatch) << true;
----------------
I think it'd be clearer to use `*IsInline` here, even though it's always `true` at this point.
http://llvm-reviews.chandlerc.com/D3057
More information about the cfe-commits
mailing list