r203473 - Replace CLANG_IS_PRODUCTION with CLANG_PLUGIN_SUPPORT.

Rafael Espindola rafael.espindola at gmail.com
Mon Mar 10 10:00:46 PDT 2014


Author: rafael
Date: Mon Mar 10 12:00:46 2014
New Revision: 203473

URL: http://llvm.org/viewvc/llvm-project?rev=203473&view=rev
Log:
Replace CLANG_IS_PRODUCTION with CLANG_PLUGIN_SUPPORT.

Modified:
    cfe/trunk/tools/driver/CMakeLists.txt
    cfe/trunk/tools/driver/Makefile

Modified: cfe/trunk/tools/driver/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/driver/CMakeLists.txt?rev=203473&r1=203472&r2=203473&view=diff
==============================================================================
--- cfe/trunk/tools/driver/CMakeLists.txt (original)
+++ cfe/trunk/tools/driver/CMakeLists.txt Mon Mar 10 12:00:46 2014
@@ -16,11 +16,11 @@ set( LLVM_LINK_COMPONENTS
   Vectorize
   )
 
-option(CLANG_IS_PRODUCTION "Build clang without plugin support" OFF)
+option(CLANG_PLUGIN_SUPPORT "Build clang with plugin support" ON)
 
 # Support plugins. This must be before add_clang_executable as it reads
 # LLVM_NO_DEAD_STRIP.
-if(NOT CLANG_IS_PRODUCTION)
+if(CLANG_PLUGIN_SUPPORT)
   set(LLVM_NO_DEAD_STRIP 1)
 endif()
 
@@ -40,7 +40,7 @@ target_link_libraries(clang
 set_target_properties(clang PROPERTIES VERSION ${CLANG_EXECUTABLE_VERSION})
 
 # Support plugins.
-if(NOT CLANG_IS_PRODUCTION)
+if(CLANG_PLUGIN_SUPPORT)
   set_target_properties(clang PROPERTIES ENABLE_EXPORTS 1)
 endif()
 

Modified: cfe/trunk/tools/driver/Makefile
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/driver/Makefile?rev=203473&r1=203472&r2=203473&view=diff
==============================================================================
--- cfe/trunk/tools/driver/Makefile (original)
+++ cfe/trunk/tools/driver/Makefile Mon Mar 10 12:00:46 2014
@@ -11,12 +11,6 @@ CLANG_LEVEL := ../..
 TOOLNAME = clang
 TOOLALIAS = clang++
 
-# We don't currently expect production Clang builds to be interested in
-# plugins. This is important for startup performance.
-ifdef CLANG_IS_PRODUCTION
-TOOL_NO_EXPORTS := 1
-endif
-
 ifdef CLANG_ORDER_FILE
 TOOL_ORDER_FILE := $(CLANG_ORDER_FILE)
 endif
@@ -24,14 +18,19 @@ endif
 # Include tool version information on OS X.
 TOOL_INFO_PLIST := Info.plist
 
-# Support plugins.
-NO_DEAD_STRIP := 1
-
 # Include this here so we can get the configuration of the targets that have
 # been configured for construction. We have to do this early so we can set up
 # LINK_COMPONENTS before including Makefile.rules
 include $(CLANG_LEVEL)/../../Makefile.config
 
+# Have the option of not supporting plugins. This is important for startup
+# performance.
+ifeq ($(CLANG_PLUGIN_SUPPORT), 1)
+NO_DEAD_STRIP := 1
+else
+TOOL_NO_EXPORTS := 1
+endif
+
 LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser bitreader bitwriter codegen \
                    instrumentation ipo irreader linker objcarcopts option \
                    selectiondag





More information about the cfe-commits mailing list