[patch] Rename CLANG_IS_PRODUCTION to CLANG_NO_PLUGIN_SUPPORT
Bob Wilson
bob.wilson at apple.com
Mon Mar 10 09:36:36 PDT 2014
On Mar 10, 2014, at 6:38 AM, Tobias Grosser <tobias at grosser.es> wrote:
> On 03/10/2014 02:35 PM, Rafael EspĂndola wrote:
>>> OK. If this is not obviously beneficial, I don't have any strong opinion
>>> here.
>>
>> Same here. It is quiet a bit more complicated and requires patching
>> llvm too, but it does avoid the double negation. Patches attached.
>
> Wow. I am impressed. Thanks Rafael for going through the trouble of doing those patches. I think I prefer the new ones over what you proposed before.
I agree. This is much more clear than CLANG_IS_PRODUCTION. I recently came across that build setting and had to dig around to see if it was still being used for anything. I like this much better.
More information about the cfe-commits
mailing list