[PATCH] Use DiagnosticRenderer to convert clang diagnostics to clang-tidy ones.

[Manuel Klimek]

  lg


================
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:95
@@ +94,3 @@
+private:
+  ClangTidyError &Output;
+};
----------------
I'd probably call it "Error". I got confused as to what this is when I read "Output" in the code above.

================
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:71
@@ +70,3 @@
+    for (auto FixIt : Hints) {
+      // FIXME: Find out if const_cast is valid here.
+      Output.Fix.insert(tooling::Replacement(const_cast<SourceManager &>(SM),
----------------
Replacement should take a const SourceManager.


http://llvm-reviews.chandlerc.com/D2950

BRANCH
  svn

ARCANIST PROJECT
  clang-tools-extra