[PATCH] [C++11] Use std::unique_ptr for ownership in a vector.
David Blaikie
dblaikie at gmail.com
Sat Mar 8 22:40:18 PST 2014
LGTM
================
Comment at: lib/ASTMatchers/Dynamic/Marshallers.h:515
@@ -514,5 +514,3 @@
- virtual ~OverloadedMatcherDescriptor() {
- llvm::DeleteContainerPointers(Overloads);
- }
+ virtual ~OverloadedMatcherDescriptor() {}
----------------
Ahmed Charles wrote:
> David Blaikie wrote:
> > Assuming this is virtual in a base class, just omit it in this class - take the implicit definition instead.
> I suppose I was being lazy and didn't want to have to try and figure that out. How about I do a pass on this class switching from virtual to override in a subsequent commit?
Sure, sounds good
http://llvm-reviews.chandlerc.com/D3016
More information about the cfe-commits
mailing list