r203029 - [-Wunreachable-code] generalize pruning out warning on trivial returns.

Ted Kremenek kremenek at apple.com
Wed Mar 5 16:52:24 PST 2014


On Mar 5, 2014, at 4:43 PM, David Blaikie <dblaikie at gmail.com> wrote:

> 
> Hmm, OK. It seems LLVM developers were/are generally happy to remove
> those returns after fully covered switches - it comes up quite often
> in code review and we diligently remove them. Do we want to
> validate/promote it? (any that are in I suspect are a matter of
> oversight rather than deliberate preference)
> 
> But I guess they're harmless enough to not be worth the warning, maybe...

No, you’re right.  The warning fires MANY times on the LLVM codebase in this case, but I agree it is worth leaving in.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140305/a832b04e/attachment.html>


More information about the cfe-commits mailing list