r202941 - [AST] A "Class<P>" type should not have '*' when printed out.

Jordan Rose jordan_rose at apple.com
Wed Mar 5 09:29:20 PST 2014



On Mar 4, 2014, at 22:47 , Argyrios Kyrtzidis <akyrtzi at gmail.com> wrote:

> -  if (!T->isObjCIdType() && !T->isObjCQualifiedIdType()) {
> +  if (!T->isObjCIdType() && !T->isObjCQualifiedIdType() &&
> +      !T->isObjCClassType() && !T->isObjCQualifiedClassType() &&
> +      !T->isObjCSelType()) {

SEL isn't an ObjCObjectPointer. (It's an opaque pointer type, but not to an object.)

Is it worth adding test cases like this? (Not that I've ever seen code like this, but it is legal...)

> typedef NSObject MyObject;
> typedef NSObject *MyObjectRef;
> 
> MyObject <NSObject> *foo;
> MyObjectRef bar;

Jordan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140305/dab9439e/attachment.html>


More information about the cfe-commits mailing list