[libcxx][PATCH] remove implementation of fmaf - fix for PR18910

Marshall Clow mclow.lists at gmail.com
Wed Mar 5 09:19:25 PST 2014


On Mar 5, 2014, at 8:34 AM, Yaron Keren <yaron.keren at gmail.com> wrote:

> Hi,
> 
> Systems without fmaf will very likely miss fmal and all the C99 functions, so they have many other problems to worry about.
> 
> LGTM. 

Thanks!
Committed revision 202990.

> One question, though. Why
> 
>  using ::fma;
>  using ::fmaf;
> 
> but not
> 
>  using ::fmal;
> 
> This is not fma specific question - cmath repeats this pattern for all C99 functions.
> Shouldn't all three version treated the same?

I don’t know.
I’ve put investigating this on my to-do list; <cmath> is due some pretty serious work in the future, mostly due to http://llvm.org/bugs/show_bug.cgi?id=18218 , and I’ll make sure that I deal with it then.

— Marshall






More information about the cfe-commits mailing list