[PATCH] [-cxx-abi microsoft] Implement local manglings accurately

[Reid Kleckner]

  lgtm


================
Comment at: include/clang/Parse/Parser.h:745
@@ -739,3 +744,3 @@
     // parser Self where the new Scope is created with the flags
     // ScopeFlags, but only when ManageScope is true (the default). If
     // ManageScope is false, this object does nothing.
----------------
Should update ManagedScope in comments.

================
Comment at: include/clang/Parse/Parser.h:748
@@ -743,1 +747,3 @@
+    ParseScope(Parser *Self, unsigned ScopeFlags, bool EnteredScope = true,
+               bool BeforeCompoundStmt = false)
       : Self(Self) {
----------------
We discussed in person that two adjacent boolean optional arguments are undesirable, but never actually reached agreement on what should be done.  Just pick something and go with it.  :)


http://llvm-reviews.chandlerc.com/D2953

BRANCH
  for_reid

ARCANIST PROJECT
  clang