[PATCH] Use the integrated assembler by default on OpenBSD/powerpc

Daniel Sanders Daniel.Sanders at imgtec.com
Tue Mar 4 05:33:48 PST 2014


You'll find four  'UseIntegratedAssembler = true;' statements in lib/Target/X86/MCTargetDesc/X86MCAsmInfo.cpp, one in each MCAsmInfo subclass. These enable the integrated assembler by default for X86. There are similar statements in other subclasses of MCAsmInfo.

The PowerPC version of this code (in PPCMCAsmInfo.cpp) currently looks like this:
	  if (T.getOS() == llvm::Triple::FreeBSD ||                                       
	      (T.getOS() == llvm::Triple::NetBSD && !is64Bit))                            
	    UseIntegratedAssembler = true;

> -----Original Message-----
> From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-
> bounces at cs.uiuc.edu] On Behalf Of Brad Smith
> Sent: 01 March 2014 23:57
> To: Rafael Espíndola
> Cc: llvm cfe
> Subject: Re: [PATCH] Use the integrated assembler by default on
> OpenBSD/powerpc
> 
> On 28/02/14 8:43 AM, Rafael Espíndola wrote:
> > On 28 February 2014 01:25, Brad Smith <brad at comstyle.com> wrote:
> >> On 27/02/14 9:43 PM, Rafael Espíndola wrote:
> >>>
> >>> Please also update MCAsmInfo, and if you are motivated, make clang
> >>> use it
> >>> :-)
> >>
> >>
> >> Not having any real familiarity with LLVM/Clang I don't know what
> >> that means.
> >
> > Oh, llvm itself also records which targets have a good integrated
> > assembler. It is in the class MCAsmInfo. We want to keep that in sync
> > with clang and eventually just have clang use that.
> 
> Well I don't see this supposed code even with the X86 target and either way
> this is outside of the scope of what I was working on.
> Please commit the diff I submitted.
> 
> 
> --
> This message has been scanned for viruses and dangerous content by
> MailScanner, and is believed to be clean.
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list