[PATCH] Sema: Treat dllimport globals without explicit storage class as extern

Richard Smith richard at metafoo.co.uk
Mon Mar 3 18:36:48 PST 2014


On Mon, Mar 3, 2014 at 6:51 AM, Nico Rieck <nico.rieck at gmail.com> wrote:

> I'm not sure if this LGTM is enough. Could anyone of the regulars take a
> quick look and greenlight this? Thanks.


I'm concerned that you may be updating the storage class too late; at the
point where you update the storage class, it's already been used for
several things. Can you move this earlier? (I expect this won't be trivial
since you can't just look for an attribute because you won't have a Decl
yet...)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140303/c69f5cac/attachment.html>


More information about the cfe-commits mailing list