Add 'remark' diagnostic type in clang

[Chris Lattner]

On Feb 26, 2014, at 2:57 PM, Arthur O'Dwyer <arthur.j.odwyer at gmail.com> wrote:

> On Wed, Feb 26, 2014 at 2:27 PM, Chris Lattner <clattner at apple.com> wrote:
>> On Feb 26, 2014, at 2:26 PM, Hal Finkel <hfinkel at anl.gov> wrote:
>>> 
>>> Remarks should often indicate things that are good (like this loop was vectorized),
>>> and so upgrading remarks to errors will only make sense for 'negative' remarks.
>> 
>> Each remark should have its own identifier, so people can choose to upgrade them
>> or not.  It’s not worth the complexity to try to add another level or behavior for
>> “positive remarks”.
> 
> Hear hear hear hear hear.
> 
> -------------
> 
> Going off on an ambitious tangent here:

If we were able to remove the existing diagnostic flags, doing these changes might be nice.  However, since we can’t, this would just a lot of complexity without making the world better :-)

-Chris