[PATCH] Sema: Definition of dllimport globals is not allowed

[Gao, Yunzhong]

Hi Nico,
Are you upgrading a warning to an error, or are you adding a new error? In the patch I do not see that you are removing the old
warning.
- Gao

________________________________________
From: cfe-commits-bounces at cs.uiuc.edu [cfe-commits-bounces at cs.uiuc.edu] on behalf of Reid Kleckner [rnk at google.com]
Sent: Wednesday, February 26, 2014 10:55 AM
To: Nico Rieck
Cc: cfe-commits at cs.uiuc.edu cfe
Subject: Re: [PATCH] Sema: Definition of dllimport globals is not allowed

LGTM, thanks!


On Wed, Feb 26, 2014 at 2:49 AM, Nico Rieck <nico.rieck at gmail.com<mailto:nico.rieck at gmail.com>> wrote:
On 22.02.2014 21:07, Nico Rieck wrote:
> This upgrades the warning when defining dllimport variables to an error
> (consistent with GCC and MSVC).

Ping.

_______________________________________________
cfe-commits mailing list
cfe-commits at cs.uiuc.edu<mailto:cfe-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits