Add 'remark' diagnostic type in clang

[Alexander Musman]

Hi Tobias,

This looks like a typo (mixed 'note' and 'remark'):

--- a/lib/Frontend/LogDiagnosticPrinter.cpp
+++ b/lib/Frontend/LogDiagnosticPrinter.cpp
@@ -31,7 +31,8 @@ LogDiagnosticPrinter::~LogDiagnosticPrinter() {
 static StringRef getLevelName(DiagnosticsEngine::Level Level) {
   switch (Level) {
   case DiagnosticsEngine::Ignored: return "ignored";
-  case DiagnosticsEngine::Note:    return "note";
+  case DiagnosticsEngine::Remark:    return "note";
+  case DiagnosticsEngine::Note:    return "remark";
   case DiagnosticsEngine::Warning: return "warning";


2014-02-25 14:20 GMT+04:00 Tobias Grosser <tobias at grosser.es>:

> Hi,
>
> I would like to add the following patch. (I submitted a corresponding
> patch to LLVM).
>
> --------------
> Add 'remark' diagnostic type in clang
>
> A 'remark' is information that is not an error or a warning, but rather
> some additional information provided to the user. In contrast to a 'note' a
> 'remark' is an independent diagnostic, whereas a 'note' always depends on
> another diagnostic.
>
> A typical use case for remark nodes is information provided to the user,
> e.g. information provided by the vectorizer about loops that have been
> vectorized.
> --------------
>
> A review would be highly appreciated.
>
> Tobias
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>


-- 
Best regards,
Alexander Musman
+79154687051
skype: alexander.musman
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140225/848df3e5/attachment.html>