[PATCH] implement -fno-short-wchar option

Richard Barton richard.barton at arm.com
Mon Feb 24 10:49:56 PST 2014


Thanks Rafael.
Committed as r202058

Thanks
Rich

> -----Original Message-----
> From: Rafael EspĂ­ndola [mailto:rafael.espindola at gmail.com]
> Sent: 24 February 2014 18:04
> To: Richard Barton
> Cc: llvm cfe
> Subject: Re: [PATCH] implement -fno-short-wchar option
> 
> LGTM
> 
> On 24 February 2014 10:55, Richard Barton <richard.barton at arm.com> wrote:
> > Hello reviewers
> >
> > The attached patch implements the -fno-short-wchar option for clang.
> >
> > I have followed the model for -fshort-wchar by only adding it to the
> > cc1 line if it is actually asked for, and leaving the default to sort
> > itself out.
> >
> > Testing added to show that it generates the right compiler defines
> > when put down. This only checks __SIZEOF_WCHAR_T and
> __WCHAR_T_WIDTH
> > as the other two are different depending on whether the default is
> > signed or unsigned. There is also a new test to make sure they turn each other
> off.
> >
> > Please review
> >
> > Thanks
> > Rich
> >
> > Richard Barton
> > Staff Engineer - LLVM
> > ARM Ltd, Cambridge
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >







More information about the cfe-commits mailing list