[PATCH] Add the option to build/test compiler-rt as a standalone project with just-built Clang.

Alexey Samsonov samsonov at google.com
Mon Feb 24 06:41:30 PST 2014



================
Comment at: runtime/CMakeLists.txt:33
@@ +32,3 @@
+    )
+  # Due to a bug, DEPENDS in ExternalProject_Add doesn't work in some CMake versions.
+  add_dependencies(compiler-rt llvm-config clang clang++)
----------------
Brad King wrote:
> This should mention the versions of CMake, 2.8.9 and 2.8.10, so that when the minimum required version is high enough in the future one may be reminded to update the code to use the DEPENDS option.
> 
Done

================
Comment at: runtime/CMakeLists.txt:45
@@ +44,3 @@
+    COMMAND ${CMAKE_COMMAND} -E make_directory <BINARY_DIR>
+    COMMENT "Clobberring compier-rt build directory..."
+    DEPENDERS configure
----------------
Evgeniy Stepanov wrote:
> typo
Done.

================
Comment at: runtime/CMakeLists.txt:38
@@ +37,3 @@
+  ExternalProject_Add_Step(compiler-rt force-reconfigure
+    DEPENDERS configure
+    ALWAYS 1
----------------
Switched this to "DEPENDERS build" per discussion on the list.

================
Comment at: runtime/CMakeLists.txt:52
@@ +51,3 @@
+  add_custom_target(check-compiler-rt
+          COMMAND ${CMAKE_BUILD_TOOL} check-all
+          DEPENDS compiler-rt
----------------
Brad King wrote:
> This can use the command
> 
> %%% 
>  ${CMAKE_COMMAND} --build . --target check-all --config $<CONFIGURATION>
> %%%
> 
> to abstract the command-line details of the native build tool.
> 
Done.


http://llvm-reviews.chandlerc.com/D2868



More information about the cfe-commits mailing list