[PATCH] Added CXXMethodDecl matcher isPureVirtual()

Konrad Kleine konrad.wilhelm.kleine at gmail.com
Mon Feb 24 01:03:27 PST 2014


Hi Manuel,

you're right. A method cannot be pure without being virtual. I think it is
safe to remove the Node.isVirtual() call and change the matcher to
"isPure". I'll try create a phabricator diff for this.

Thank you so far for the review.


2014-02-23 20:43 GMT+01:00 Manuel Klimek <klimek at google.com>:

> Can a method be pure without being virtual?
>
>
> On Fri, Feb 21, 2014 at 5:30 PM, Dmitri Gribenko <gribozavr at gmail.com>wrote:
>
>> On Fri, Feb 21, 2014 at 4:24 PM, Konrad Kleine
>> <konrad.wilhelm.kleine at gmail.com> wrote:
>> > Hi,
>> >
>> > I've added a new CXXMethodDecl matcher: isPureVirtual().
>>
>> + Manuel
>>
>> --
>> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
>> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140224/28d240b8/attachment.html>


More information about the cfe-commits mailing list