[PATCH] Refactor parsing for MSVC function style pragmas

Reid Kleckner rnk at google.com
Fri Feb 21 15:28:35 PST 2014


Hi majnemer,

Not for commit.

This tries to share some of the code that parses function style pragmas.  I
wasn't happy with the code savings, and it's harder to issue good diagnostics.
Therefore, I'm probably going to skip this, unless anyone has some good ideas
on how to do this better.

http://llvm-reviews.chandlerc.com/D2861

Files:
  include/clang/Basic/DiagnosticParseKinds.td
  lib/Lex/Pragma.cpp
  lib/Lex/Preprocessor.cpp
  lib/Parse/ParsePragma.cpp
  test/Preprocessor/pragma_microsoft.c
  test/SemaCXX/member-pointer-ms.cpp
  test/SemaCXX/pragma-vtordisp.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2861.1.patch
Type: text/x-patch
Size: 17411 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140221/6091cd95/attachment.bin>


More information about the cfe-commits mailing list