r190980 - Make Preprocessor::Lex non-recursive.

Joerg Sonnenberger joerg at britannica.bec.de
Fri Feb 21 14:08:30 PST 2014


On Fri, Feb 21, 2014 at 01:24:06PM -0800, Richard Smith wrote:
> On Thu, Feb 20, 2014 at 5:46 PM, Joerg Sonnenberger <joerg at britannica.bec.de
> > wrote:
> 
> > On Thu, Feb 20, 2014 at 01:49:29PM -0800, Richard Smith wrote:
> > > On Thu, Feb 20, 2014 at 12:07 PM, Joerg Sonnenberger <
> > > joerg at britannica.bec.de> wrote:
> > >
> > > > On Thu, Sep 19, 2013 at 12:41:32AM -0000, Eli Friedman wrote:
> > > > > Author: efriedma
> > > > > Date: Wed Sep 18 19:41:32 2013
> > > > > New Revision: 190980
> > > > >
> > > > > URL: http://llvm.org/viewvc/llvm-project?rev=190980&view=rev
> > > > > Log:
> > > > > Make Preprocessor::Lex non-recursive.
> > > >
> > > > This is eating a newline in assembler sources. Can you investigate,
> > > > please? Test case:
> > > >
> > > > #define __CHECK_FPU
> > > > #define RESTORE_FPU __CHECK_FPU stx %l2, [0]
> > > > restore % 0,, %o0
> > > > RESTORE_FPU
> > > >
> > > > Before, restore and stx are on separate as expected. After this change,
> > > > they end up on the same line.
> > > >
> > >
> > > I believe that Harald van Dijk has a patch out for review that fixes
> > this.
> >
> > I tried it, but no luck.
> >
> 
> There were two patches on the thread, and I pointed you at the message with
> the wrong one (sorry if I misled you). Does the other one help:
> 
> http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20140203/098523.html

That one is better :) Commit!

Joerg



More information about the cfe-commits mailing list