[PATCH] Adding _mm_prefetch and other builtins
Hans Wennborg
hans at chromium.org
Wed Feb 19 14:50:52 PST 2014
Looks good to me, just a nit about one of the test files.
================
Comment at: test/CodeGen/ms-builtins.c:14
@@ +13,3 @@
+ __noop();
+ __debugbreak();
+};
----------------
The __noop() and __debugbreak() seem redundant for the test..
================
Comment at: test/CodeGen/ms-builtins.c:17
@@ +16,3 @@
+
+int main() {
+ volatile long b = 0;
----------------
.. as does this main() function and printf(). I assume they were used for local testing, but I don't think we should commit them.
http://llvm-reviews.chandlerc.com/D2822
More information about the cfe-commits
mailing list