[PATCH] Fix for Bug 18536 - Bad alignment in clang/AST/StmpOpenMP.h

Doug Gregor dgregor at apple.com
Tue Feb 18 13:16:44 PST 2014


  The second argument to RoundUpToAlignment is an alignment, not a size...


================
Comment at: include/clang/AST/StmtOpenMP.h:84
@@ +83,3 @@
+                   reinterpret_cast<char *>(this) +
+                   llvm::RoundUpToAlignment(sizeof(T), sizeof(Expr *))),
+            NumVars);
----------------
The second argument here should be llvm::alignOf<Expr*>(), shouldn't it?

================
Comment at: include/clang/AST/StmtOpenMP.h:95
@@ -92,1 +94,3 @@
+                   reinterpret_cast<char *>(this) +
+                   llvm::RoundUpToAlignment(sizeof(T), sizeof(Expr *))));
   }
----------------
Same here (and several more below).


http://llvm-reviews.chandlerc.com/D2713



More information about the cfe-commits mailing list