r201537 - PR18839: 'extern "C++"' also adds an implicit 'extern', not just 'extern "C"'.

[cdavis5x at gmail.com]

On Feb 17, 2014, at 4:34 PM, Richard Smith <richard-llvm at metafoo.co.uk> wrote:
> Modified: cfe/trunk/test/CodeGenCXX/extern-c.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/extern-c.cpp?rev=201537&r1=201536&r2=201537&view=diff
> ==============================================================================
> --- cfe/trunk/test/CodeGenCXX/extern-c.cpp (original)
> +++ cfe/trunk/test/CodeGenCXX/extern-c.cpp Mon Feb 17 17:34:47 2014
> @@ -1,18 +1,22 @@
> // RUN: %clang_cc1 -triple %itanium_abi_triple -emit-llvm %s -o - | FileCheck %s
> namespace foo {
> 
> -// CHECK-NOT: @a = global i32
> +// CHECK-NOT: @a = global
> extern "C" int a;
> 
> -// CHECK-NOT: @_ZN3foo1bE = global i32
> +// CHECK-NOT: @_ZN3foo1bE = global
> extern int b;
> 
> -// CHECK: @_ZN3foo1cE = global i32
> +// CHECK: @_ZN3foo1cE = global
> int c = 5;
> 
> // CHECK-NOT: @_ZN3foo1dE
> extern "C" struct d;
> 
> +// CHECK-NOT: @e = global
> +// CHECK-NOT: @_ZN3foo1eE = global
> +extern "C++" int a2;
> +
Are you sure this test is testing what you intended it to?

Chip