[PATCH] Some infrastructure work for virtual file system (now on phab)
Dmitri Gribenko
gribozavr at gmail.com
Fri Feb 14 17:16:43 PST 2014
================
Comment at: include/clang/Basic/VirtualFileSystem.h:87-90
@@ +86,6 @@
+public:
+ /// \brief Destroy the file after closing it (if open).
+ /// Sub-classes should generally call close() inside their destructors. We
+ /// cannot do that from the base class, since close is virtual.
+ virtual ~File();
+ /// \brief Get the status of the file.
----------------
Dmitri Gribenko wrote:
> I could be misunderstanding something, but why not call the virtual close() from this destructor?
Right, we can not do that. Please disregard this comment.
http://llvm-reviews.chandlerc.com/D2745
More information about the cfe-commits
mailing list