r201428 - [IRGen]. Fixes a crash in using Objective-C array

[Fariborz Jahanian]

Author: fjahanian
Date: Fri Feb 14 13:37:25 2014
New Revision: 201428

URL: http://llvm.org/viewvc/llvm-project?rev=201428&view=rev
Log:
[IRGen]. Fixes a crash in using Objective-C array  
properties by fixing shouldBindAsLValue to accept arrays
(like record types) because we always manipulate
them in memory. Patch suggested by John MaCall.
// rdar://15610943

Added:
    cfe/trunk/test/CodeGenObjC/property-array-type.m
Modified:
    cfe/trunk/lib/CodeGen/CodeGenFunction.h

Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenFunction.h?rev=201428&r1=201427&r2=201428&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CodeGenFunction.h (original)
+++ cfe/trunk/lib/CodeGen/CodeGenFunction.h Fri Feb 14 13:37:25 2014
@@ -688,8 +688,8 @@ public:
       // act exactly like l-values but are formally required to be
       // r-values in C.
       return expr->isGLValue() ||
-             expr->getType()->isRecordType() ||
-             expr->getType()->isFunctionType();
+             expr->getType()->isFunctionType() ||
+             hasAggregateEvaluationKind(expr->getType());
     }
 
     static OpaqueValueMappingData bind(CodeGenFunction &CGF,

Added: cfe/trunk/test/CodeGenObjC/property-array-type.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenObjC/property-array-type.m?rev=201428&view=auto
==============================================================================
--- cfe/trunk/test/CodeGenObjC/property-array-type.m (added)
+++ cfe/trunk/test/CodeGenObjC/property-array-type.m Fri Feb 14 13:37:25 2014
@@ -0,0 +1,30 @@
+// RUN: %clang_cc1 -triple x86_64-apple-darwin10  -emit-llvm -o - %s | FileCheck %s
+// rdar://15610943
+
+struct _GLKMatrix4
+{
+    float m[16];
+};
+typedef struct _GLKMatrix4 GLKMatrix4;
+
+ at interface NSObject @end
+
+ at interface MyProgram
+- (void)setTransform:(float[16])transform;
+ at end
+
+ at interface ViewController
+ at property (nonatomic, assign) GLKMatrix4 transform;
+ at end
+
+ at implementation ViewController
+- (void)viewDidLoad {
+  MyProgram *program;
+  program.transform = self.transform.m;
+}
+ at end
+
+// CHECK: [[M:%.*]] = getelementptr inbounds %struct._GLKMatrix4* [[TMP:%.*]], i32 0, i32 0
+// CHECK: [[ARRAYDECAY:%.*]] = getelementptr inbounds [16 x float]* [[M]], i32 0, i32 0
+// CHECK: [[SIX:%.*]] = load i8** @"\01L_OBJC_SELECTOR_REFERENCES
+// CHECK:  call void bitcast (i8* (i8*, i8*, ...)* @objc_msgSend to void (i8*, i8*, float*)*)(i8* [[SEVEN:%.*]], i8* [[SIX]], float* [[ARRAYDECAY]])