[PATCH] AArch64: look up BuiltinID before calling EmitAArch64ScalarBuiltinExpr
Tim Northover
t.p.northover at gmail.com
Fri Feb 14 02:17:06 PST 2014
I ended up finishing the work actually making use of this table and decided there wasn't actually any benefit to splitting it into two stages, so here's the complete idea.
I changed the code from referring directly to __builtin_neon_XYZ to just mentioning XYZ for two reasons: it allows automatic generation of the NameHint field which goes into LLVM IR on asserts builds, and it reduces the width of the table.
There are still a handful of 80 column violations (by no more than 3 chars), but I tend to think they're better than the alternatives at this stage.
How does the entire thing look?
Cheers.
Tim.
http://llvm-reviews.chandlerc.com/D2764
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D2764?vs=7058&id=7118#toc
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/aarch64-neon-ld-sideeffect.c
utils/TableGen/NeonEmitter.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2764.2.patch
Type: text/x-patch
Size: 57323 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140214/8db5a448/attachment.bin>
More information about the cfe-commits
mailing list