r201256 - [examples] Use loadable modules instead of shared libraries for Clang plugins.
Jordan Rose
jordan_rose at apple.com
Thu Feb 13 10:18:12 PST 2014
On Feb 13, 2014, at 8:46 , Jordan Rose <jordan_rose at apple.com> wrote:
>
> On Feb 13, 2014, at 7:57 , NAKAMURA Takumi <geek4civic at gmail.com> wrote:
>
>> One-point nitpick; Did you really need to add dependencies to these libraries?
>
> I thought about this. Since we don't link to any of these libraries, we shouldn't need them. But then I thought we'd want to recompile this plugin if any of them changed. However, today I realized CMake should already be looking at the header files as dependencies (by scanning includes), so I can probably drop them.
>
>> I guess you would like ClangCommentCommandList here.
>
>
> Good point. This is the template for any future checker plugins, including ones that look at comments. I'll fix both of these issues.
r201350.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140213/eaab089e/attachment.html>
More information about the cfe-commits
mailing list