[PATCH] Fix ExplicitConstructorCheck to warn only on in-class declarations.

[Daniel Jasper]

  LG.


================
Comment at: clang-tidy/google/GoogleTidyModule.cpp:34
@@ +33,3 @@
+      Result.Nodes.getNodeAs<CXXConstructorDecl>("ctor");
+  if (Ctor->isOutOfLine() || Ctor->isExplicit() || Ctor->isImplicit())
+    return;
----------------
Maybe add a small comment explaining that isExplicit and isImplicit do very different things. Otherwise this looks like it would always return.


http://llvm-reviews.chandlerc.com/D2756

BRANCH
  svn

ARCANIST PROJECT
  clang-tools-extra