[PATCH] Verify source files for a module only once during the build

Dmitri Gribenko gribozavr at gmail.com
Wed Feb 12 02:39:40 PST 2014


On Wed, Feb 12, 2014 at 2:49 AM, Argyrios Kyrtzidis <kyrtzidis at apple.com> wrote:
> +/**
> + * \brief Return the timestamp for use with Clang's
> + * \c -fbuild-session-timestamp= option.
> + */
> +CINDEX_LINKAGE unsigned long long clang_getBuildSessionTimestamp(void);
>
> You should bump the libclang API version.
>
> +// RUN: find %t/modules-cache -name Foo.pcm | xargs -I {} cp {} %t/modules-to-compare/Foo-before.pcm
>
> You can use “-fdisable-module-hash” to get a predictable path to the module file, the file will be at %t/modules-cache/Foo.pcm
>
> Otherwise, LGTM!

Thank you for the review!  Committed r201224.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/




More information about the cfe-commits mailing list