[PATCH] [OPENMP] 'if' clause support

Dmitri Gribenko gribozavr at gmail.com
Mon Feb 10 06:42:32 PST 2014


  There are no tests for template instantiation, as far as I see.

  When committing, please also mention that this does not include CodeGen support.


================
Comment at: lib/Parse/ParseOpenMP.cpp:343
@@ +342,3 @@
+                                             T.getOpenLocation(),
+                                             Tok.getLocation());
+}
----------------
Tok.getLocation() should be T.getCloseLocation()?


================
Comment at: test/OpenMP/parallel_if_messages.cpp:21
@@ +20,3 @@
+  #pragma omp parallel if (S1) // expected-error {{'S1' does not refer to a value}}
+  #pragma omp parallel if (argv[1]=2) // expected-error {{expected ')'}} expected-note {{to match this '('}}
+  foo();
----------------
Could you add where an incomplete 'if' is not at the end of the directive?

#pragma omp parallel if ( if ( foo (bar)

this should reasonable recovery now that the parser uses BalancedDelimiterTracker.


http://llvm-reviews.chandlerc.com/D2719



More information about the cfe-commits mailing list