CMake SVNVersion fixes

Chandler Carruth chandlerc at google.com
Sun Feb 9 13:44:14 PST 2014


Note that the clang side is totally hosed here compared to the LLVM side.
Compare the CMake code in Clang to VersionFromVCS.cmake which can handle
subversion, git, and git-svn gracefully. I can't even really test these
patches because clang gives up (i think) when it fails to find a .svn
directory.

I think it would be better to switch clang to use VersionFromVCS.cmake and
then consolidate improvements there.


On Sun, Feb 9, 2014 at 1:08 PM, Dmitri Gribenko <gribozavr at gmail.com> wrote:

> On Sun, Feb 9, 2014 at 7:25 PM, Kim Gräsman <kim.grasman at gmail.com> wrote:
> > ping.
>
> + Jordan, who was working on this part of code recently, if I recall
> correctly.
>
> Dmitri
>
> --
> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140209/049216ef/attachment.html>


More information about the cfe-commits mailing list