CMake SVNVersion fixes

Kim Gräsman kim.grasman at gmail.com
Sun Feb 9 11:25:16 PST 2014


ping.

On Sun, Jan 26, 2014 at 10:38 PM, Kim Gräsman <kim.grasman at gmail.com> wrote:
> Hello,
>
> The CMake build doesn't generate SVNVersion.inc correctly, it mixes up
> *_REPOSITORY and *_VERSION and doesn't even generate *_REPOSITORY.
>
> The consequence of this is that clang/Basic/Version.h/.cpp returns
> incorrect results for clang::get*Revision and
> clang::get*RepositoryPath.
>
> Attached are two patches, one for LLVM and one for Clang, to fix this.
> I don't have commit access and I'm not subscribed to llvm-commits, so
> if we could figure this out on this list, that would be great.
>
> It'd be nice to get tests in place for these things, but I'm not
> entirely sure how to formulate them in a stable way.
>
> - Kim




More information about the cfe-commits mailing list