[PATCH] MS ABI: Add support for #pragma pointers_to_members

Reid Kleckner rnk at google.com
Fri Feb 7 15:39:08 PST 2014



================
Comment at: include/clang/Basic/TokenKinds.def:679
@@ +678,3 @@
+// handles them.
+ANNOTATION(pragma_ms_pointers_to_members)
+
----------------
I thought we were trying to get away from these annotation tokens for pragmas, but I've forgotten what the alternative proposal was.

================
Comment at: include/clang/Sema/Sema.h:265
@@ -264,1 +264,3 @@
 
+  enum PragmaMSPointersToMembersKind {
+    PPTMK_BestCase,
----------------
This is a mouthful, and the initialization is long.  Maybe DefaultMSInheritanceModel?  *shrug*

================
Comment at: include/clang/Sema/Sema.h:6984
@@ +6983,3 @@
+  /// ActOnPragmaMSPointersToMembers - called on well formed \#pragma
+  /// pointers_to_members(representation method, [general purose
+  /// representation]).
----------------
s/purose/purpose/


http://llvm-reviews.chandlerc.com/D2723



More information about the cfe-commits mailing list