[PATCH] AAPCS-VFP: double and long double have the same machine type

[Renato Golin]

On 6 February 2014 15:03, Oliver Stannard <oliver.stannard at arm.com> wrote:

> I was mistaken, that check was required, because this code is shared
> between ARM and AArch64.  I have attached an updated patch which puts the
> check back in, and adds a test for this in AArch64.
>

Hi Oliver,

That's not what I meant... ;)

AFAICT, the ABI says that double and long double have the same size, so why
does the original comparison fail in the first place?

I mean, from what you said, this: Context.getTypeSize(Base) !=
Context.getTypeSize(TyPtr) should return false for the cases: {d, d}, {d,
ld}, {ld, d} and {ld, ld} on ARM, and true for the two central ones in
AArch64. No?

If it doesn't, it would be good to understand why not, and fix it at the
source. And if it can't be fixed at the source, than a good explanation of
why not on the comment is welcome.

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140206/95d59fe5/attachment.html>