[PATCH] Add diagnostic capabilities in LLVM (frontend part)

Quentin Colombet qcolombet at apple.com
Wed Feb 5 15:23:05 PST 2014


  Hi Dmitri,

  Thanks for the review.
  I have fixed all the points you’d mentioned but I’d like you to check if I used the -verify the way you had in mind.
  As for 2 to Impl, I did that for consistency with the surrounding code (this is the way the inline asm handler was implemented). Still I agree with you and I have fixed that.

  Thanks,
  -Quentin

Hi gribozavr, hfinkel,

http://llvm-reviews.chandlerc.com/D2430

CHANGE SINCE LAST DIFF
  http://llvm-reviews.chandlerc.com/D2430?vs=6864&id=6907#toc

Files:
  include/clang/Basic/DiagnosticCategories.td
  include/clang/Basic/DiagnosticFrontendKinds.td
  include/clang/Basic/DiagnosticGroups.td
  lib/CodeGen/CodeGenAction.cpp
  test/Frontend/backend-diagnostic.c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2430.3.patch
Type: text/x-patch
Size: 10163 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140205/6673d7c2/attachment.bin>


More information about the cfe-commits mailing list