[PATCH] Add a -verify-pch option to clang -cc1

Ben Langmuir blangmuir at apple.com
Wed Feb 5 14:29:33 PST 2014


On Feb 5, 2014, at 8:11 AM, Argyrios Kyrtzidis <kyrtzidis at apple.com> wrote:

> Sorry for the delay!
> 
> On Jan 24, 2014, at 9:58 AM, Ben Langmuir <blangmuir at apple.com> wrote:
> 
>> Based on an off-list discussion, I’ve updated this patch to not check for configuration mismatches (e.g. different langopts), since checking for staleness is the interesting case to check for and adding all the requisite langopts to the command line increases the complexity of using the feature.
> 
> +  /// for configuration differences between the AST file and the invokation.
> 
> typo: ‘invocation'

I don’t know why, but I always spell invocation incorrectly the first time.  Good catch.  

> 
> Also this doesn't verify system headers, do you plan to do this after you commit this patch ?
> 

Yep, I’ll commit that separately.

> 
> Otherwise, LGTM!


Great, thank!  r200884



More information about the cfe-commits mailing list