libcxxabi PATCH: Fix for PR17223 - catching a base pointer when a derived null pointer was thrown

Marshall Clow mclow.lists at gmail.com
Wed Feb 5 10:27:39 PST 2014


On Feb 5, 2014, at 10:00 AM, Howard Hinnant <howard.hinnant at gmail.com> wrote:

> On Feb 5, 2014, at 12:50 PM, Marshall Clow <mclow.lists at gmail.com> wrote:
> 
>> Turns out you have to treat NULL special.
>> Added a couple tests.
> 
> This looks awesome!  I recommend a test throwing nullptr as well, just as a sanity check.  

Good idea. Done and committed as revision 200864 .

> And I think, but am not sure, that http://llvm.org/bugs/show_bug.cgi?id=17221 might be a duplicate.  

Sadly, not a duplicate.
I added a test, and it fails.

> And http://llvm.org/bugs/show_bug.cgi?id=17222 is in the same neighborhood, but probably not a duplicate.

Definitely not a duplicate.

— Marshall





More information about the cfe-commits mailing list