[PATCH] Don't mark declarations with mismatching exception specs as invalid in MS mode (PR18683)

Richard Smith richard at metafoo.co.uk
Tue Feb 4 17:19:40 PST 2014



================
Comment at: lib/Sema/SemaExceptionSpec.cpp:185-188
@@ -184,6 +184,6 @@
   // The failure was something other than an missing exception
-  // specification; return an error.
+  // specification; return an error, except in MS mode where this is a warning.
   if (!MissingExceptionSpecification)
-    return true;
+    return getLangOpts().MicrosoftExt ? false : true;
 
   const FunctionProtoType *NewProto =
----------------
Can you put this conditional in the same place where we determine if we're producing a warning or an error?


http://llvm-reviews.chandlerc.com/D2681



More information about the cfe-commits mailing list