[PATCH] MS ABI: Mangle member pointer template arguments

[David Majnemer]

================
Comment at: lib/CodeGen/CGCXXABI.h:46
@@ -45,3 +45,3 @@
 
-  CGCXXABI(CodeGenModule &CGM)
-    : CGM(CGM), MangleCtx(CGM.getContext().createMangleContext()) {}
+  CGCXXABI(CodeGenModule &CGM, MangleContext *MangleCtx)
+    : CGM(CGM), MangleCtx(MangleCtx) {}
----------------
Why did this constructor change? I can't find a place where `MangleCtx` isn't `CGM.getContext().createMangleContext()`.

================
Comment at: lib/Sema/SemaTemplate.cpp:4542
@@ +4541,3 @@
+          << Arg->getSourceRange();
+      S.Diag(Param->getLocation(), diag::note_template_param_here);
+    }
----------------
How hard would it be to make this an error when the mangling is truly erroneous?


http://llvm-reviews.chandlerc.com/D2695