[PATCH] Allow transformation of VariableArray to ConstantArray.

[David Blaikie]

================
Comment at: test/SemaCXX/crashes.cpp:235
@@ +234,3 @@
+
+namespace pr18633 {
+  struct A1 {
----------------
While the existence of this test file might imply otherwise - in my opinion, we should never simply have a test that "doesn't crash". There must be some ultimate behavior expected of the compiler that was never reached due to the crash - that's missing test coverage that should be added.

(also, presumably there are some related test cases in a more specific test file somewhere that this should be grouped with, perhaps - either the non-templated case, or a template test that tests some similar functionality but missed this case (but I know it's sometimes hard to track down the right test cases - sometimes it can be done by evoking diagnostics for similar features - but since this test has no diagnostics I guess it should be a codegen test))


http://llvm-reviews.chandlerc.com/D2688