Prevent module import inside @implementation

Ben Langmuir blangmuir at apple.com
Mon Feb 3 14:32:36 PST 2014


Based on a suggestion from Jordan I’ve dropped the extra note, which will be on the same location anyway, and added that information into the error diagnostic.  I would have liked to say "treating #include ...” instead of  "treating directive …", but after the preprocessor/lexer this information is lost and I don’t see a nice way to pass it on to the parser.

Ben

-------------- next part --------------
A non-text attachment was scrubbed...
Name: import-in-impl.patch
Type: application/octet-stream
Size: 4042 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140203/a6cdc341/attachment.obj>
-------------- next part --------------



On Feb 3, 2014, at 10:19 AM, Ben Langmuir <blangmuir at apple.com> wrote:

> This patch disallows module import inside @implementaiton, and also moves the parsing for implicit imports (e.g. #import) into the same function as explicit imports (@import).  Previously we silently accepted explicit imports in @implementation, but gave a missing ‘@end’ error on implicit imports.
> 
> Ben
> 
> <import-in-impl.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list