r200533 - [CMake] clang doesn't care whether CLANG_ENABLE_*(s) were set or not.

[Jordan Rose]

Aha, good call. Thanks for the explanation.

Jordan


On Jan 31, 2014, at 17:15 , NAKAMURA Takumi <geek4civic at gmail.com> wrote:

> I have confirmed, in the actual command line, libraries are not linked.
> 
> lib/libclangARCMigrate.a
> lib/libclangStaticAnalyzerCheckers.a
> lib/libclangStaticAnalyzerCore.a
> lib/libclangStaticAnalyzerFrontend.a
> 
> They are dropped when 3 of CLANG_ENABLE_ are OFF.
> See also clang/lib/FrontendTool/CMakeLists.txt .
> 
> ...Takumi
> 
> 2014-02-01 Jordan Rose <jordan_rose at apple.com>:
>> Um? How does the static analyzer get linked into Clang, then?
>> 
>> On Jan 31, 2014, at 3:19, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
>> 
>>> Author: chapuni
>>> Date: Fri Jan 31 05:19:15 2014
>>> New Revision: 200533
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=200533&view=rev
>>> Log:
>>> [CMake] clang doesn't care whether CLANG_ENABLE_*(s) were set or not.
>>> 
>>> Modified:
>>>   cfe/trunk/tools/driver/CMakeLists.txt
>>> 
>>> Modified: cfe/trunk/tools/driver/CMakeLists.txt
>>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/driver/CMakeLists.txt?rev=200533&r1=200532&r2=200533&view=diff
>>> ==============================================================================
>>> --- cfe/trunk/tools/driver/CMakeLists.txt (original)
>>> +++ cfe/trunk/tools/driver/CMakeLists.txt Fri Jan 31 05:19:15 2014
>>> @@ -32,27 +32,6 @@ target_link_libraries(clang
>>>  clangFrontendTool
>>>  )
>>> 
>>> -if(CLANG_ENABLE_STATIC_ANALYZER)
>>> -  target_link_libraries(clang
>>> -    clangStaticAnalyzerFrontend
>>> -    clangStaticAnalyzerCheckers
>>> -    clangStaticAnalyzerCore
>>> -    )
>>> -endif()
>>> -
>>> -if(CLANG_ENABLE_ARCMT)
>>> -  target_link_libraries(clang
>>> -    clangARCMigrate
>>> -    )
>>> -endif()
>>> -
>>> -if(CLANG_ENABLE_REWRITER)
>>> -  target_link_libraries(clang
>>> -    clangRewriteCore
>>> -    clangRewriteFrontend
>>> -    )
>>> -endif()
>>> -
>>> set_target_properties(clang PROPERTIES VERSION ${CLANG_EXECUTABLE_VERSION})
>>> set_target_properties(clang PROPERTIES ENABLE_EXPORTS 1)
>>> 
>>> 
>>> 
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>