[PATCH] [ms-cxxabi] Use x86_cdeclmethodcc for __cdecl methods on win32

Richard Smith richard at metafoo.co.uk
Fri Jan 31 13:41:40 PST 2014


  Go ahead. We can revisit this if someone comes up with a better approach than adding the flag to `CGFunctionInfo`.


================
Comment at: lib/CodeGen/CodeGenABITypes.cpp:67-68
@@ -66,3 +66,4 @@
                                          RequiredArgs args) {
-  return CGM->getTypes().arrangeLLVMFunctionInfo(returnType, argTypes,
-                                                info, args);
+  // We assume callers don't use this to get the LLVM types for C++ methods.
+  bool IsInstanceMethod = false;
+  return CGM->getTypes().arrangeLLVMFunctionInfo(returnType, IsInstanceMethod,
----------------
You don't need this comment any more, I don't think.


http://llvm-reviews.chandlerc.com/D2664

BRANCH
  x86_cdecl_method_cc

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list