Extend IdenticalExprChecker to find more potential problems

Daniel Fahlgren daniel at fahlgren.se
Fri Jan 31 10:43:20 PST 2014


Hi Jordan

On Thu, 2014-01-30 at 09:47 -0800, Jordan Rose wrote:
> Hi, Daniel. Can you split these two checks up into separate patches? I
> know they're pretty similar and have the same basic idea, but we like
> to have commits be limited to one new feature at a time. (Combining
> bitwise and logical operators into one is fine, though.) Sorry it's a
> bit more work for you to tease them apart.

Thanks for taking the time and look at this. I'll try to address your
comments during the weekend.

Cheers,
Daniel Fahlgren




More information about the cfe-commits mailing list