[PATCH] Slightly better handling of transparent_union attribute

Aaron Ballman aaron at aaronballman.com
Mon Jan 27 17:53:02 PST 2014


Thanks! Committed in r200277

~Aaron

On Mon, Jan 27, 2014 at 8:48 PM, Richard Smith <metafoo at gmail.com> wrote:
> LGTM, thanks!
>
>
> On Mon Jan 27 2014 at 5:46:11 PM, Aaron Ballman <aaron at aaronballman.com>
> wrote:
>>
>> This patch addresses PR15134; we were being too strict with our
>> checking of alignments for transparent union members. This patch
>> relaxes the alignment checking rules by only enforcing the diagnostic
>> when subsequent alignments are more strict than the original
>> alignment.
>>
>> I've also added a FIXME to the code to describe at least one of the
>> ways we're not handling the attribute semantics quite right.
>>
>> ~Aaron



More information about the cfe-commits mailing list