r200132 - Enforce safe usage of DiagnosticsEngine::getCustomDiagID()

[Alp Toker]

On 26/01/2014 07:17, Chandler Carruth wrote:
>
> On Sat, Jan 25, 2014 at 11:09 PM, Rafael Espíndola 
> <rafael.espindola at gmail.com <mailto:rafael.espindola at gmail.com>> wrote:
>
>     > Docstrings updated in r200137.
>     >
>     > It the builders are enforcing -Wdocumentation it should really
>     also be
>     > enabled in the default CMake configuration.
>
>     I think we used to have on build bot using it.
>
>     I noticed because I find it useful and have it enabled locally. So I
>     agree, it would be nice have cmake enable it by default :-)
>
>
> It has been discussed several times. The warning has a very 
> non-trivial compile time overhead, so it made sense to enable it on a 
> couple of bots rather than by default.

I couldn't find a PR?

If a non-analysis feature is slow enough that we can't use it ourselves 
it then it's not ready to ship -- could you file a PR with the details 
you remember and links to any discussions?

The comment lexer/parser/sema is very heavy right now but I suspect we 
can get a lot of mileage out of a highly simplified alternative scheme 
that'd be sufficient to support -Wcomments and refactoring.

CC'ing in Dmitri so we can get a handle on this. I'd like to help

Alp.

-- 
http://www.nuanti.com
the browser experts