CMake SVNVersion fixes

Kim Gräsman kim.grasman at gmail.com
Sun Jan 26 13:38:09 PST 2014


Hello,

The CMake build doesn't generate SVNVersion.inc correctly, it mixes up
*_REPOSITORY and *_VERSION and doesn't even generate *_REPOSITORY.

The consequence of this is that clang/Basic/Version.h/.cpp returns
incorrect results for clang::get*Revision and
clang::get*RepositoryPath.

Attached are two patches, one for LLVM and one for Clang, to fix this.
I don't have commit access and I'm not subscribed to llvm-commits, so
if we could figure this out on this list, that would be great.

It'd be nice to get tests in place for these things, but I'm not
entirely sure how to formulate them in a stable way.

- Kim
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Clang-SVNVersion.patch
Type: application/octet-stream
Size: 589 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140126/eef1e4dd/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: LLVM-SVNVersion.patch
Type: application/octet-stream
Size: 1680 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140126/eef1e4dd/attachment-0001.obj>


More information about the cfe-commits mailing list